Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix multiple partition column statistics (backport #50488) #50635

Closed
wants to merge 1 commit into from
Closed

[BugFix] fix multiple partition column statistics (backport #50488) #50635

wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 3, 2024 •
edited by wanpengfei-git
Loading

Why I'm doing:

What I'm doing:

  • For multi-column list partition, any column should be considered as the statistics

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5
This is an automatic backport of pull request #50488 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

  • For multi-column list partition, any column should be considered as the statistics

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@murphyatwork @mergify
[BugFix] fix multiple partition column statistics (#50488)
6b57a4e 
Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 7bdc5bf)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
#	test/lib/sr_sql_lib.py
@mergify mergify bot added the conflicts label Sep 3, 2024
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Sep 3, 2024

Cherry-pick of 7bdc5bf has failed:

On branch mergify/bp/branch-3.1/pr-50488
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit 7bdc5bf563.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   test/sql/test_list_partition/R/test_list_partition_cardinality
	new file:   test/sql/test_list_partition/T/test_list_partition_cardinality

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java
	both modified:   test/lib/sr_sql_lib.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Sep 3, 2024
Merged
24 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 3, 2024 10:43
@mergify mergify bot closed this Sep 3, 2024
auto-merge was automatically disabled September 3, 2024 10:43

Pull request was closed

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Sep 3, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.1/pr-50488 branch September 3, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@murphyatwork murphyatwork

Labels
automerge conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@murphyatwork